spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request #13531: [SPARK-15654] [SQL] fix non-splitable files for t...
Date Thu, 09 Jun 2016 16:51:57 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13531#discussion_r66478617
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala
---
    @@ -298,6 +309,28 @@ trait FileFormat {
     }
     
     /**
    + * The base class file format that is based on text file.
    + */
    +abstract class TextBasedFileFormat extends FileFormat {
    +  private var codecFactory: CompressionCodecFactory = null
    +  override def isSplitable(
    +      sparkSession: SparkSession,
    +      options: Map[String, String],
    +      path: Path): Boolean = {
    +    if (codecFactory == null) {
    +      synchronized {
    +        if (codecFactory == null) {
    +          codecFactory = new CompressionCodecFactory(
    --- End diff --
    
    There could be "io.compression.codecs" in options, it's used by getCodec().
    
    Since all other APIs have that, it's better to have that here too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message