spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request #13473: [SPARK-15736][CORE] Gracefully handle loss of Dis...
Date Fri, 03 Jun 2016 02:17:21 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13473#discussion_r65648664
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -403,6 +403,17 @@ private[spark] class BlockManager(
       }
     
       /**
    +   * Cleanup code run in response to a failed local read.
    +   * Must be called while holding a read lock on the block.
    +   */
    +  private def handleLocalReadFailure(blockId: BlockId): Nothing = {
    +    releaseLock(blockId)
    +    // Remove the missing block so that its unavailability is reported to the driver
    +    removeBlock(blockId)
    --- End diff --
    
    No, I don't think so: internally, `removeBlock` acquires a write lock on the block, so
if we called it before the `releaseLock` call then we'd be calling it while holding a read
lock which would cause us to deadlock.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message