spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #13470: [SPARK-15733][SQL] Makes the explain output less ...
Date Thu, 02 Jun 2016 20:28:39 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13470#discussion_r65612428
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
    @@ -427,13 +427,21 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends
Product {
       private lazy val allChildren: Set[TreeNode[_]] = (children ++ innerChildren).toSet[TreeNode[_]]
     
       /** Returns a string representing the arguments to this node, minus any children */
    -  def argString: String = productIterator.flatMap {
    +  def argString: String = stringArgs.flatMap {
         case tn: TreeNode[_] if allChildren.contains(tn) => Nil
         case Some(tn: TreeNode[_]) if allChildren.contains(tn) => Nil
    -    case tn: TreeNode[_] => s"${tn.simpleString}" :: Nil
    -    case seq: Seq[BaseType] if seq.toSet.subsetOf(children.toSet) => Nil
    -    case seq: Seq[_] => seq.mkString("[", ",", "]") :: Nil
    -    case set: Set[_] => set.mkString("{", ",", "}") :: Nil
    +    case tn: TreeNode[_] => tn.simpleString :: Nil
    +    case seq: Seq[Any] if seq.toSet.subsetOf(allChildren.asInstanceOf[Set[Any]]) =>
Nil
    --- End diff --
    
    oh sorry I just realized we are using `allChildren` instead `children.toSet`, then this
is fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message