spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #13380: [SPARK-15644] [MLlib] [SQL] Replace SQLContext wi...
Date Thu, 02 Jun 2016 01:54:14 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13380#discussion_r65473285
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ---
    @@ -109,7 +109,7 @@ class SparkSession private(
        * A wrapped version of this session in the form of a [[SQLContext]], for backward
compatibility.
        */
       @transient
    -  private[sql] val sqlContext: SQLContext = new SQLContext(this)
    +  private[spark] val sqlContext: SQLContext = new SQLContext(this)
    --- End diff --
    
    @rxin Is that OK? Here, the reason why I changed is for the call in https://github.com/gatorsmile/spark/blob/7dcaaa4539324d596c290ca189adc2e65d77bb0c/mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala#L76


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message