Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: ericl <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-13318-spark@git.apache.org>
In-Reply-To: <git-pr-13318-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-15391] [SQL] manage the temporary
 memor...
Content-Type: text/plain
Message-Id: <20160526072955.A772CDFC13@git1-us-west.apache.org>
Date: Thu, 26 May 2016 07:29:55 +0000 (UTC)

Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13318#discussion_r64701761
  
    --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
    @@ -101,14 +94,17 @@ public void expandPointerArray(LongArray newArray) {
           array.getBaseOffset(),
           newArray.getBaseObject(),
           newArray.getBaseOffset(),
    -      array.size() * (8 / memoryAllocationFactor)
    +      pos * 8
    --- End diff --
    
    I think we should keep the memoryAllocationFactor variable, to make it more clear we are overallocating on purpose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org