Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: yanboliang <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-13129-spark@git.apache.org>
In-Reply-To: <git-pr-13129-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-15339] [ML] ML 2.0 QA: Scala APIs
 and c...
Content-Type: text/plain
Message-Id: <20160518122232.62370DFB79@git1-us-west.apache.org>
Date: Wed, 18 May 2016 12:22:32 +0000 (UTC)

Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13129#discussion_r63692508
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala ---
    @@ -107,7 +107,7 @@ private[regression] trait GeneralizedLinearRegressionBase extends PredictorParam
             s"with ${$(family)} family does not support ${$(link)} link function.")
         }
         val newSchema = super.validateAndTransformSchema(schema, fitting, featuresDataType)
    -    if ($(linkPredictionCol).nonEmpty) {
    +    if (isDefined(linkPredictionCol) && $(linkPredictionCol).nonEmpty) {
    --- End diff --
    
    Good point, updated. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org