Return-Path: 
 <reviews-return-365798-apmail-spark-reviews-archive=spark.apache.org@spark.apache.org>
X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org
Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id AB9D018743
	for <apmail-spark-reviews-archive@minotaur.apache.org>;
 Tue, 17 May 2016 17:31:31 +0000 (UTC)
Received: (qmail 99967 invoked by uid 500); 17 May 2016 17:31:31 -0000
Delivered-To: apmail-spark-reviews-archive@spark.apache.org
Received: (qmail 99951 invoked by uid 500); 17 May 2016 17:31:31 -0000
Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@spark.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@spark.apache.org>
List-Post: <mailto:reviews@spark.apache.org>
List-Id: <reviews.spark.apache.org>
Delivered-To: mailing list reviews@spark.apache.org
Received: (qmail 99505 invoked by uid 99); 17 May 2016 17:31:31 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 May 2016 17:31:31 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 2F066DFD9F; Tue, 17 May 2016 17:31:31 +0000 (UTC)
From: srowen <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-13057-spark@git.apache.org>
In-Reply-To: <git-pr-13057-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-15273]
 YarnSparkHadoopUtil#getOutOfMemo...
Content-Type: text/plain
Message-Id: <20160517173131.2F066DFD9F@git1-us-west.apache.org>
Date: Tue, 17 May 2016 17:31:31 +0000 (UTC)

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13057#discussion_r63567123
  
    --- Diff: launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java ---
    @@ -334,6 +334,18 @@ static void addPermGenSizeOpt(List<String> cmd) {
       }
     
       /**
    +   * Gets the OutOfMemoryError option for Spark if the user hasn't set it.
    +   */
    +  public static void addOutOfMemoryErrorArgument(List<String> cmd) {
    --- End diff --
    
    Sure, maybe ...
    
    ```
    if (!javaOpts.exists(_.contains("...")) {
      javaOpts.add("...")
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org