Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 484B3194AE for ; Wed, 11 May 2016 15:18:36 +0000 (UTC) Received: (qmail 37898 invoked by uid 500); 11 May 2016 15:18:36 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 37874 invoked by uid 500); 11 May 2016 15:18:36 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 37863 invoked by uid 99); 11 May 2016 15:18:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 15:18:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 96E29DFC77; Wed, 11 May 2016 15:18:35 +0000 (UTC) From: sethah To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-15243][ML][PYSPARK] Param methods shoul... Content-Type: text/plain Message-Id: <20160511151835.96E29DFC77@git1-us-west.apache.org> Date: Wed, 11 May 2016 15:18:35 +0000 (UTC) Github user sethah commented on the pull request: https://github.com/apache/spark/pull/13036#issuecomment-218492143 Currently investigating some other usages of `isinstance(obj, str)` for this PR. Will update soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org