Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 70D1919E86 for ; Wed, 11 May 2016 07:30:39 +0000 (UTC) Received: (qmail 77757 invoked by uid 500); 11 May 2016 07:30:39 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 77735 invoked by uid 500); 11 May 2016 07:30:39 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 77724 invoked by uid 99); 11 May 2016 07:30:39 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 07:30:39 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F38E4DFCC0; Wed, 11 May 2016 07:30:38 +0000 (UTC) From: dbtsai To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-15268][SQL] Make JavaTypeInference work... Content-Type: text/plain Message-Id: <20160511073038.F38E4DFCC0@git1-us-west.apache.org> Date: Wed, 11 May 2016 07:30:38 +0000 (UTC) Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13046#discussion_r62802522 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/VectorUDTSuite.scala --- @@ -17,9 +17,19 @@ package org.apache.spark.ml.linalg +import scala.beans.BeanInfo + import org.apache.spark.SparkFunSuite +import org.apache.spark.sql.catalyst.JavaTypeInference import org.apache.spark.sql.types._ +@BeanInfo +case class LabeledPoint(label: Double, features: Vector) { + override def toString: String = { + s"($label,$features)" + } +} --- End diff -- TODO, I'll remove this `LabeledPoint ` class in https://github.com/apache/spark/pull/12627 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org