Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: dongjoon-hyun <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-12719-spark@git.apache.org>
In-Reply-To: <git-pr-12719-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-14939][SQL] Add
 FoldablePropagation opt...
Content-Type: text/plain
Message-Id: <20160511042135.DF33EDFBDE@git1-us-west.apache.org>
Date: Wed, 11 May 2016 04:21:35 +0000 (UTC)

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12719#discussion_r62790052
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -650,15 +646,15 @@ object FoldablePropagation extends Rule[LogicalPlan] {
     
         if (foldableExprSet.isEmpty) {
           plan
    -    } else if (hasCommandOrUnion(plan)) {
    -      replaceInSubplan(plan)
         } else {
           val foldableMap = AttributeMap(foldableExprSet.toSeq.map(_.asInstanceOf[Alias])
             .map(a => (a.toAttribute, a.child)))
     
    -      CleanupAliases(plan.transformAllExpressions {
    -        case a : AttributeReference if foldableMap.contains(a) =>
    -          Alias(foldableMap.getOrElse(a.toAttribute, a), a.name)()
    +      CleanupAliases(plan.transformUp {
    +        case p: LogicalPlan if !hasCommandOrUnion(p) => p.transformAllExpressions {
    +          case a: AttributeReference if foldableMap.contains(a) =>
    +            Alias(foldableMap.getOrElse(a.toAttribute, a), a.name)()
    +        }
    --- End diff --
    
    By the way, in the above code using `stop` flag, if earlier sibling has `Union`, the later sibling is disabled. So, it's not safe. It's just an example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org