Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: andrewor14 <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-12935-spark@git.apache.org>
In-Reply-To: <git-pr-12935-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-15160][SQL] support data source
 table i...
Content-Type: text/plain
Message-Id: <20160505204443.6BF09DFC6C@git1-us-west.apache.org>
Date: Thu,  5 May 2016 20:44:43 +0000 (UTC)

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12935#discussion_r62251940
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ---
    @@ -77,6 +78,22 @@ private[sql] object DataSourceAnalysis extends Rule[LogicalPlan] {
       }
     }
     
    +
    +/**
    + * Replaces [[SimpleCatalogRelation]] with data source table if its table property contains data
    + * source information.
    + */
    +private[sql] class FindDataSourceTable(sparkSession: SparkSession) extends Rule[LogicalPlan] {
    +  override def apply(plan: LogicalPlan): LogicalPlan = plan transform {
    +    case i @ logical.InsertIntoTable(s: SimpleCatalogRelation, _, _, _, _) =>
    --- End diff --
    
    don't we need to check whether this is a datasource table here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org