Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: NarineK <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-12887-spark@git.apache.org>
In-Reply-To: <git-pr-12887-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-15110][SparkR] Implement
 repartitionByC...
Content-Type: text/plain
Message-Id: <20160504231610.4B4CDDFB38@git1-us-west.apache.org>
Date: Wed,  4 May 2016 23:16:10 +0000 (UTC)

Github user NarineK commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12887#discussion_r62130439
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -586,11 +593,22 @@ setMethod("unpersist",
     #' path <- "path/to/file.json"
     #' df <- read.json(sqlContext, path)
     #' newDF <- repartition(df, 2L)
    +#' newDF <- repartition(df, numPartitions = 2L)
    +#' newDF <- repartition(df, col = df$"col1", df$"col2")
     #'}
     setMethod("repartition",
    -          signature(x = "SparkDataFrame", numPartitions = "numeric"),
    -          function(x, numPartitions) {
    -            sdf <- callJMethod(x@sdf, "repartition", numToInt(numPartitions))
    +          signature(x = "SparkDataFrame"),
    +          function(x, numPartitions = NULL, col = NULL, ...) {
    +            if (!is.null(numPartitions) && (class(numPartitions) == "numeric"
    +              || class(numPartitions) == "integer")) {
    --- End diff --
    
    yeah, that's more elegant!
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org