Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: liancheng <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-12872-spark@git.apache.org>
In-Reply-To: <git-pr-12872-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-6339][SQL] Supports create CREATE
 TEMPO...
Content-Type: text/plain
Message-Id: <20160504100957.B5AB6DFB14@git1-us-west.apache.org>
Date: Wed,  4 May 2016 10:09:57 +0000 (UTC)

Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12872#discussion_r62016689
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala ---
    @@ -57,6 +67,35 @@ class SQLViewSuite extends QueryTest with SQLTestUtils with TestHiveSingleton {
         }
       }
     
    +  test("error handling: fail if the temp view name contains the database prefix") {
    +    // Full qualified table name is not allowed
    --- End diff --
    
    Nit: "Fully" qualified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org