Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F155193FF for ; Tue, 3 May 2016 21:10:43 +0000 (UTC) Received: (qmail 81324 invoked by uid 500); 3 May 2016 21:10:43 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 81300 invoked by uid 500); 3 May 2016 21:10:43 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 81289 invoked by uid 99); 3 May 2016 21:10:42 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 May 2016 21:10:42 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id AAAD2DFB90; Tue, 3 May 2016 21:10:42 +0000 (UTC) From: hvanhovell To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-14127][SQL] Native "DESC [EXTENDED | FO... Content-Type: text/plain Message-Id: <20160503211042.AAAD2DFB90@git1-us-west.apache.org> Date: Tue, 3 May 2016 21:10:42 +0000 (UTC) Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12844#discussion_r61956757 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1012,6 +1017,7 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder { entry("field.delim", ctx.fieldsTerminatedBy) ++ entry("serialization.format", ctx.fieldsTerminatedBy) ++ entry("escape.delim", ctx.escapedBy) ++ + // The following typo is inherited from Hive... --- End diff -- +1 for this comment. Totally got me the last time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org