spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14507] [SQL] EXTERNAL keyword in a CTAS...
Date Sun, 29 May 2016 18:32:47 GMT
GitHub user yhuai opened a pull request:

    https://github.com/apache/spark/pull/13395

    [SPARK-14507] [SQL] EXTERNAL keyword in a CTAS statement is not allowed

    ## What changes were proposed in this pull request?
    This PR makes the parser to throw an exception if a hive style CTAS command has an external
keyword. The main reason of this change is to make the syntax consistent with CREATE TABLE
USING AS SELECT syntax (it does not allow EXTERNAL keyword).
    
    Another options is to make `EXTERNAL` keyword optional. 
    
    ## How was this patch tested?
    HiveDDLCommandSuite
    
    **NOTE: This PR is based on https://github.com/apache/spark/pull/13386, which needs to
be merged first.**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yhuai/spark SPARK-14507-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13395
    
----
commit f613d9e6687ac306f54d2e82276561ec5eb6a1ac
Author: Yin Huai <yhuai@databricks.com>
Date:   2016-05-28T23:18:49Z

    test cases

commit 1e22d53cb2089841cc4dba4dd71066bb9915c9d6
Author: Yin Huai <yhuai@databricks.com>
Date:   2016-05-28T23:19:45Z

    Move the conversion logic to the parser.

commit 2615f676844d19b33552f60cd2849522d5564360
Author: Yin Huai <yhuai@databricks.com>
Date:   2016-05-28T23:32:05Z

    Update tests

commit c5cb32cf98248a1941c16b9ed605780f20cbca75
Author: Yin Huai <yhuai@databricks.com>
Date:   2016-05-29T04:46:08Z

    Hive style CTAS command does not allow EXTERNAL keyword and PARTITIONED BY clause.

commit 220a6e0d76f110f6423d96ce0b25e29e8fcb19f9
Author: Yin Huai <yhuai@databricks.com>
Date:   2016-05-29T17:47:49Z

    wip

commit fa8908122a238d6cdc0a9fc0f003221ef5601565
Author: Yin Huai <yhuai@databricks.com>
Date:   2016-05-29T18:18:47Z

    Changes related to EXTERNAL will be handled in another PR.

commit 27332df39b36e781c311b35383338f5deb478eea
Author: Yin Huai <yhuai@databricks.com>
Date:   2016-05-29T18:26:28Z

    [SPARK-14507] [SQL] EXTERNAL keyword in a CTAS statement is not allowed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message