spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15297] [SQL] Fix Set -V Command
Date Thu, 12 May 2016 17:27:34 GMT
GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/13081

    [SPARK-15297] [SQL] Fix Set -V Command

    #### What changes were proposed in this pull request?
    The command `SET -v` always outputs the default values even if we set the parameter. This
behavior is incorrect. Instead, if users override it, we should output the user-specified
value.
    
    In addition, the output schema of "SET -v" is wrong. We should use the column `value`
instead of `default` for the parameter value.
    
    This command is to fix the above two issues. 
    
    #### How was this patch tested?
    Added a test case. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark setVcommand

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13081.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13081
    
----
commit c351e9b67a82e8a6905661aab706fff9e74a8851
Author: gatorsmile <gatorsmile@gmail.com>
Date:   2016-05-12T17:18:45Z

    fix.

commit 6a233551f84da58eb2231545237402c0eaa72124
Author: gatorsmile <gatorsmile@gmail.com>
Date:   2016-05-12T17:26:59Z

    remove unnecessary import

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message