spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NarineK <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12922][SparkR][WIP] Implement gapply() ...
Date Tue, 31 May 2016 03:45:38 GMT
Github user NarineK commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12836#discussion_r65120599
  
    --- Diff: R/pkg/inst/worker/worker.R ---
    @@ -84,67 +84,78 @@ broadcastElap <- elapsedSecs()
     # as number of partitions to create.
     numPartitions <- SparkR:::readInt(inputCon)
     
    -isDataFrame <- as.logical(SparkR:::readInt(inputCon))
    +# 0 - RDD mode, 1 - dapply mode, 2 - gapply mode
    +mode <- SparkR:::readInt(inputCon)
     
    -# If isDataFrame, then read column names
    -if (isDataFrame) {
    +# If DataFrame - mode = 1 and mode = 2, then read column names
    +if (mode > 0) {
    --- End diff --
    
    I ended up leaving mode as is. I also think that one variable is less confusing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message