spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15580][SQL]Add ContinuousQueryInfo to m...
Date Fri, 27 May 2016 19:09:39 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13335#discussion_r64953763
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/util/ContinuousQueryListener.scala
---
    @@ -65,11 +65,23 @@ object ContinuousQueryListener {
       trait Event
     
       /** Event representing the start of a query */
    -  class QueryStarted private[sql](val query: ContinuousQuery) extends Event
    +  class QueryStarted private[sql](val queryInfo: ContinuousQueryInfo) extends Event
     
       /** Event representing any progress updates in a query */
    -  class QueryProgress private[sql](val query: ContinuousQuery) extends Event
    +  class QueryProgress private[sql](val queryInfo: ContinuousQueryInfo) extends Event
     
       /** Event representing that termination of a query */
    -  class QueryTerminated private[sql](val query: ContinuousQuery) extends Event
    +  class QueryTerminated private[sql](val queryInfo: ContinuousQueryInfo) extends Event
     }
    +
    +/**
    + * :: Experimental ::
    + * A class that contains information about [[ContinuousQuery]].
    + */
    +@Experimental
    +case class ContinuousQueryInfo(
    +    name: String,
    +    isActive: Boolean,
    +    sourceStatuses: Seq[SourceStatus],
    +    sinkStatus: SinkStatus,
    +    exception: Option[ContinuousQueryException])
    --- End diff --
    
    Good catch. We should use `string` instead of `ContinuousQueryException`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message