spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [YARN][Doc][Minor] Remove several obsolete env...
Date Thu, 26 May 2016 13:17:29 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13296#discussion_r64742672
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -99,6 +101,8 @@ to the same log file).
     
     If you need a reference to the proper location to put log files in the YARN so that YARN
can properly display and aggregate them, use `spark.yarn.app.container.log.dir` in your `log4j.properties`.
For example, `log4j.appender.file_appender.File=${spark.yarn.app.container.log.dir}/spark.log`.
For streaming applications, configuring `RollingFileAppender` and setting file location to
YARN's log directory will avoid disk overflow caused by large log files, and logs can be accessed
using YARN's log utility.
     
    +To use a custom metrics.properties for the application master and executors, just update
the `$SPARK_CONF_DIR/metrics.properties` file, it will automatically uploaded with other configurations,
so you don't need to specify it manually with --files.
    --- End diff --
    
    Remove "just"; "file, it will automatically" -> "file. It will automatically be". Back-tick
`--files`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message