spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MLnick <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15100][DOC] Modified user guide and exa...
Date Thu, 26 May 2016 06:45:27 GMT
Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13176#discussion_r64698136
  
    --- Diff: docs/ml-features.md ---
    @@ -53,7 +53,10 @@ collisions, where different raw features may become the same term after
hashing.
     chance of collision, we can increase the target feature dimension, i.e. the number of
buckets 
     of the hash table. Since a simple modulo is used to transform the hash function to a
column index, 
    --- End diff --
    
    I think we can add it - but we can simply say "The hash function used is MurmurHash 3"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message