spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...
Date Wed, 25 May 2016 21:22:34 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11996#discussion_r64655722
  
    --- Diff: core/src/test/scala/org/apache/spark/ui/jobs/JobProgressListenerSuite.scala
---
    @@ -254,6 +253,11 @@ class JobProgressListenerSuite extends SparkFunSuite with LocalSparkContext
with
           assert(listener.stageIdToData((task.stageId, 0)).numFailedTasks === failCount)
         }
     
    +    // Check the killed tasks count.
    --- End diff --
    
    change to "Make sure killed tasks are accounted for correctly"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message