spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15439][SparkR]:Failed to run unit test ...
Date Wed, 25 May 2016 06:22:28 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13284#discussion_r64520757
  
    --- Diff: R/pkg/inst/tests/testthat/test_context.R ---
    @@ -24,10 +24,18 @@ test_that("Check masked functions", {
       func <- lapply(masked, function(x) { capture.output(showMethods(x))[[1]] })
       funcSparkROrEmpty <- grepl("\\(package SparkR\\)$|^$", func)
       maskedBySparkR <- masked[funcSparkROrEmpty]
    -  namesOfMasked <- c("describe", "cov", "filter", "lag", "na.omit", "predict", "sd",
"var",
    -                     "colnames", "colnames<-", "intersect", "rank", "rbind", "sample",
"subset",
    -                     "summary", "transform", "drop", "window", "as.data.frame",
    -                     "endsWith", "startsWith")
    +  if (as.numeric(R.version$major) == 3 && as.numeric(R.version$minor) > 2)
{
    --- End diff --
    
    can we just append to the list ? i.e. create `namesOfMasked` outside this and if the version
number is greater than 2 we can do 
    `namesOfMasked <- c("endsWith", "startsWith", namesOfMasked)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message