spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...
Date Mon, 23 May 2016 14:40:05 GMT
Github user squito commented on the pull request:

    https://github.com/apache/spark/pull/8559#issuecomment-220999599
  
    @markhamstra thanks for the review.  I went ahead and added one more commit and removed
`DummyExternalClusterManager`, just used Mock in the old tests.  Honestly I kinda prefer having
`ExternalClusterManagerSuite` being very simple and self-contained, but also don't feel particularly
strongly about it.  (easy to back out since its just one final commit.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message