spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [HOTFIX][SPARK-15445] Build fails for java 1.7...
Date Fri, 20 May 2016 19:43:37 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13223#discussion_r64096905
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
    @@ -132,17 +133,15 @@ final class Decimal extends Ordered[Decimal] with Serializable {
        * Set this Decimal to the given BigInteger value. Will have precision 38 and scale
0.
        */
       def set(bigintval: BigInteger): Decimal = {
    -    try {
    -      this.decimalVal = null
    -      this.longVal = bigintval.longValueExact()
    -      this._precision = DecimalType.MAX_PRECISION
    -      this._scale = 0
    -      this
    -    }
    -    catch {
    -      case e: ArithmeticException =>
    -        throw new IllegalArgumentException(s"BigInteger ${bigintval} too large for decimal")
    -     }
    +    // TODO: Remove this once we migrate to java8 and use longValueExact() instead.
    +    require(
    --- End diff --
    
    Doesn't this have a potential perf hit? Also - is this actually related to the problem
this ticket is solving?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message