spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...
Date Thu, 19 May 2016 23:13:58 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13163#discussion_r63969163
  
    --- Diff: launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
    @@ -59,6 +59,17 @@ public void testClusterCmdBuilder() throws Exception {
       }
     
       @Test
    +  public void testCliHelpAndNoArg() throws Exception {
    +    List<String> sparkSubmitArgs = Arrays.asList(parser.HELP);
    +    Map<String, String> env = new HashMap<>();
    +    List<String> cmd = buildCommand(sparkSubmitArgs, env);
    +
    +    List<String> sparkEmptyArgs = Arrays.asList("");
    +    cmd = buildCommand(sparkSubmitArgs, env);
    --- End diff --
    
    Ah, there's a problem here. This line should be testing `sparkEmptyArgs`. And at that
point the assert needs to be moved up a bit.
    
    In fact, it's better to have two separate test methods (one for help, one for empty).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message