spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...
Date Thu, 19 May 2016 02:31:52 GMT
Github user dongjoon-hyun commented on the pull request:

    https://github.com/apache/spark/pull/12719#issuecomment-220212554
  
    Oops. Analyzing by modifying `checkEvaluation` is not helpful in this case. For example,
`CastSuite`,
    ```
        {
          val ret = cast(array_notNull, ArrayType(BooleanType, containsNull = false))
          assert(ret.resolved === false)
          checkEvaluation(ret, Seq(null, true, false))
        }
    ```
    The test case is designed to make 'unresolved' case and check the result intentionally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message