spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <>
Subject [GitHub] spark pull request: [SPARK-15203][Deploy]The spark daemon shell sc...
Date Wed, 18 May 2016 17:17:14 GMT
Github user srowen commented on a diff in the pull request:
    --- Diff: sbin/ ---
    @@ -162,6 +162,16 @@ run_command() {
       echo "$newpid" > "$pid"
    +  #here add this loop to check the daemon process turn into java process. It takes at
most 5 seconds.
    --- End diff --
    This would be somewhat clearer as something like "Poll for up to 5 seconds for the java
process to start" Otherwise LGTM

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message