spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Date Wed, 18 May 2016 09:40:51 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13158#discussion_r63673599
  
    --- Diff: core/src/main/resources/org/apache/spark/ui/static/timeline-view.js ---
    @@ -26,7 +26,10 @@ function drawApplicationTimeline(groupArray, eventObjArray, startTime)
{
         editable: false,
         showCurrentTime: false,
         min: startTime,
    -    zoomable: false
    +    zoomable: false,
    +    moment: function (date) {
    +      return vis.moment(date).utcOffset(offset);
    --- End diff --
    
    Unfortunately, [moment](http://momentjs.com/docs/#/manipulating/utc-offset/) (used by
`vis`) only supports the followings. Actually, this PR is using the last one, `minute` format.
    ```javascript
    moment().utcOffset("+08:00");
    moment().utcOffset(8);   // hour: -16 < x < 16
    moment().utcOffset(480); // minutes
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message