spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15370] [SQL] Update RewriteCorrelatedSc...
Date Wed, 18 May 2016 06:34:26 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13155#discussion_r63651943
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
    @@ -1648,16 +1648,56 @@ object RewriteCorrelatedScalarSubquery extends Rule[LogicalPlan]
{
       }
     
       /**
    +   * Statically evaluate an expression containing one or more aggregates on an empty
input.
    +   */
    +  private def evalOnZeroTups(expr : Expression) : Option[Any] = {
    +    // AggregateExpressions are Unevaluable, so we need to replace all aggregates
    +    // in the expression with the value they would return for zero input tuples.
    +    val rewrittenExpr = expr transform {
    +      case a @ AggregateExpression(aggFunc, _, _, resultId) =>
    +        val resultLit = aggFunc.defaultResult match {
    +          case Some(lit) => lit
    +          case None => Literal.default(NullType)
    +        }
    +        Alias(resultLit, "aggVal") (exprId = resultId)
    --- End diff --
    
    Nit: space


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message