spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarutak <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15165][SQL] Codegen can break because t...
Date Wed, 18 May 2016 05:51:18 GMT
Github user sarutak commented on the pull request:

    https://github.com/apache/spark/pull/12939#issuecomment-219931480
  
    Lots of punctuation characters like `*`, `+` can be used as an operator in expressions
so I'm afraid comments in generated code will be difficult to read if characters are removed
based on the whitelist.
    
    On the other hand, I noticed my another PR (#12979) can keep the readability of the comment
 and the safety.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message