spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python...
Date Wed, 18 May 2016 03:33:04 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13135#discussion_r63640687
  
    --- Diff: examples/src/main/python/ml/simple_params_example.py ---
    @@ -36,18 +35,20 @@
         if len(sys.argv) > 1:
    --- End diff --
    
    I see.. Hm.. but I don't think this is meaningless but means explicitly not taking arguments.

    
    Actually, I think all the examples (not taking arguments) should check this for consistency
because some of example scripts (taking arguments) are already checking this.
    
    Strictly, running this example with arguments might not be a proper way to run this example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message