spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15346] [MLlib] Reduce duplicate computa...
Date Tue, 17 May 2016 10:25:17 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13133#discussion_r63498667
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LocalKMeans.scala ---
    @@ -46,17 +46,15 @@ private[mllib] object LocalKMeans extends Logging {
     
         // Initialize centers by sampling using the k-means++ procedure.
         centers(0) = pickWeighted(rand, points, weights).toDense
    +    val costArray = points.map(KMeans.fastSquaredDistance(_, centers(0)))
    +
         for (i <- 1 until k) {
    -      // Pick the next center with a probability proportional to cost under current centers
    -      val curCenters = centers.view.take(i)
    -      val sum = points.view.zip(weights).map { case (p, w) =>
    -        w * KMeans.pointCost(curCenters, p)
    -      }.sum
    +      val sum = costArray.view.zip(weights).map(p => p._1 * p._2).sum
    --- End diff --
    
    Remove .view? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message