spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6706] [MLlib] Reduce duplicate computat...
Date Mon, 16 May 2016 10:29:54 GMT
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/13133#issuecomment-219395513
  
    @mouendless this does not appear to be directly related to SPARK-6706, and it has a lot
of style problems.
    
    After a first pass, I don't think this is valid. You have changed the computation to ignore
the point's distance to previous centers. Right? Of course that's faster, but I don't believe
it's correct.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message