spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...
Date Sat, 14 May 2016 13:37:57 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10125#discussion_r63276311
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
    @@ -129,6 +129,23 @@ final class Decimal extends Ordered[Decimal] with Serializable {
       }
     
       /**
    +   * Set this Decimal to the given BigInteger value. Will have precision 38 and scale
0.
    +   */
    +  def set(BigIntVal: BigInteger): Decimal = {
    --- End diff --
    
    lower case the variable name


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message