spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15273] YarnSparkHadoopUtil#getOutOfMemo...
Date Thu, 12 May 2016 10:19:30 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13057#discussion_r62997037
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala ---
    @@ -418,11 +418,16 @@ object YarnSparkHadoopUtil {
        *
        * @return The correct OOM Error handler JVM option, platform dependent.
        */
    -  def getOutOfMemoryErrorArgument: String = {
    +  def getOutOfMemoryErrorArgument(sparkConf: SparkConf, javaOpts: ListBuffer[String]):
String = {
         if (Utils.isWindows) {
           escapeForShell("-XX:OnOutOfMemoryError=taskkill /F /PID %%%%p")
         } else {
    -      "-XX:OnOutOfMemoryError='kill %p'"
    +      val onOOME = javaOpts.find(x => x.contains("-XX:OnOutOfMemoryError"))
    +      if (onOOME == None) {
    --- End diff --
    
    There are several things wrong with this Scala code, but more generally, this isn't a
good way to design this method. If you really mean to optionally add an argument, then see
how things like the PermGen argument are handled and make it work more that way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message