spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15080][CORE] Break copyAndReset into co...
Date Wed, 11 May 2016 06:19:14 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12936#discussion_r62796474
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
---
    @@ -29,9 +29,18 @@ class SQLMetric(val metricType: String, initValue: Long = 0L) extends
Accumulato
       // We may use -1 as initial value of the accumulator, if the accumulator is valid,
we will
       // update it at the end of task and the value will be at least 0. Then we can filter
out the -1
       // values before calculate max, min, etc.
    -  private[this] var _value = initValue
    +  private var _value = initValue
    --- End diff --
    
    yup


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message