spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lianhuiwang <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-4452][Core][HOT-FIX] Fix code style and...
Date Tue, 10 May 2016 04:23:25 GMT
Github user lianhuiwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13020#discussion_r62610536
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/Spillable.scala ---
    @@ -41,7 +41,7 @@ private[spark] abstract class Spillable[C](taskMemoryManager: TaskMemoryManager)
       protected def forceSpill(): Boolean
     
       // Number of elements read from input since last spill
    -  @volatile protected def elementsRead: Long = _elementsRead
    +  protected def elementsRead: Long = _elementsRead
    --- End diff --
    
    It has only one thread to use this method.  So we can remove volatile.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message