spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15187] [SQL] Disallow Dropping Default ...
Date Sat, 07 May 2016 13:37:27 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12962#discussion_r62416413
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
    @@ -118,6 +118,9 @@ class SessionCatalog(
       }
     
       def dropDatabase(db: String, ignoreIfNotExists: Boolean, cascade: Boolean): Unit =
{
    +    if (db == "default") {
    --- End diff --
    
    You are asking a very great question! Actually, I am not very sure how it works. 
    
    First, the current code base is not considering case sensitivity in database names. That
part is missing. I think we should call `toLowerCase` for all the cases.
    
    Second, I saw we have a function `formatTableName` for formatting table names based on
the configuration of `CASE_SENSITIVE`. However, the underlying Hive metastore is not case
sensitive. See the document: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL
    
    My question is how to achieve the case sensitivity when using Hive metastore? also cc
@yhuai 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message