spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15113][PySpark][ML] Add missing num fea...
Date Fri, 06 May 2016 19:46:52 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12889#discussion_r62381355
  
    --- Diff: python/pyspark/ml/regression.py ---
    @@ -708,7 +710,7 @@ def _create_model(self, java_model):
     
     
     @inherit_doc
    -class DecisionTreeModel(JavaModel):
    +class DecisionTreeModel(JavaModel, JavaPredictionModel):
    --- End diff --
    
    I was going to leave the ones which aren't base classes for classification models for
whoever picks up update the regression models (`DecisionTreeModel` is the base for `DecisionTreeClassificationModel`
so I updated it).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message