spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14139][SQL] RowEncoder should preserve ...
Date Thu, 05 May 2016 06:55:13 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12364#discussion_r62153695
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala
---
    @@ -34,9 +34,8 @@ import org.apache.spark.unsafe.types.UTF8String
     object RowEncoder {
       def apply(schema: StructType): ExpressionEncoder[Row] = {
         val cls = classOf[Row]
    -    val inputObject = BoundReference(0, ObjectType(cls), nullable = true)
    -    // We use an If expression to wrap extractorsFor result of StructType
    -    val serializer = serializerFor(inputObject, schema).asInstanceOf[If].falseValue
    +    val inputObject = BoundReference(0, ObjectType(cls), nullable = false)
    --- End diff --
    
    Probably add a comment here. It's not super intuitive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message