spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15031][EXAMPLE] Use SparkSession in Sca...
Date Wed, 04 May 2016 21:04:56 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12809#discussion_r62114725
  
    --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/DecisionTreeExample.scala
---
    @@ -167,17 +167,17 @@ object DecisionTreeExample {
           testInput: String,
           algo: String,
           fracTest: Double): (DataFrame, DataFrame) = {
    -    val sqlContext = new SQLContext(sc)
    +    val spark = SparkSession.builder.getOrCreate()
    --- End diff --
    
    I wonder if we should have an internal `SparkSession.builder.create(sc)`. It's kind of
weird to just ignore the argument. That's a separate issue though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message