spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14684] [SPARK-15026] [SQL] Disallow Dro...
Date Wed, 04 May 2016 20:33:05 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12801#discussion_r62109483
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -400,6 +400,10 @@ case class AlterTableDropPartition(
           throw new AnalysisException(
             "ALTER TABLE DROP PARTITIONS is not allowed for tables defined using the datasource
API")
         }
    +    if (specs.size > 1) {
    +      throw new AnalysisException(
    +        s"Alter Table Drop Partition is not allowed to drop more than one partitions.")
    --- End diff --
    
    actually I don't think we should throw an exception here. Let's move the discussion to
the main thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message