spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lw-lin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-15022][SPARK-15023][SQL][Streaming] Add...
Date Wed, 04 May 2016 00:04:52 GMT
Github user lw-lin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12797#discussion_r61976475
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala ---
    @@ -142,7 +142,10 @@ trait StreamTest extends QueryTest with Timeouts {
       case object StopStream extends StreamAction with StreamMustBeRunning
     
       /** Starts the stream, resuming if data has already been processed.  It must not be
running. */
    -  case object StartStream extends StreamAction
    +  case class StartStream(trigger: Trigger = null, triggerClock: Clock = null) extends
StreamAction
    --- End diff --
    
    This layer of `null`s was intended to delegate the default values of `StreamExecution`
into these tests, so that we don't have to set the same default values in many places and
maintain their consistency. But since it seems very unlikely that we would change the default
values, so I've removed the `null`s and followed your comments.
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message