spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...
Date Mon, 02 May 2016 22:10:06 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12846#discussion_r61813606
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -717,12 +717,11 @@ private[sql] class SQLConf extends Serializable with CatalystConf
with Logging {
     
       /**
        * Return the value of an optional Spark SQL configuration property for the given key.
If the key
    -   * is not set yet, throw an exception.
    +   * is not set yet, returns None.
        */
    -  def getConf[T](entry: OptionalConfigEntry[T]): T = {
    +  def getOptionalConf[T](entry: OptionalConfigEntry[T]): Option[T] = {
    --- End diff --
    
    This method is now only used in the tests you're adding... so it could be removed, and
your tests slightly changed, to just use the existing `getConf`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message