spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11962] WIP: Added `attempt` and `getOpt...
Date Mon, 02 May 2016 18:21:08 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12708#discussion_r61779384
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
    @@ -335,6 +358,19 @@ trait Row extends Serializable {
       def getAs[T](fieldName: String): T = getAs[T](fieldIndex(fieldName))
     
       /**
    +   * Returns the value of a given fieldName as a scala.util.Try object.
    +   */
    +  def attempt[T](fieldName: String): Try[T] = Try(getAs[T](fieldIndex(fieldName)))
    --- End diff --
    
    As I said on the other PR, I don't understand the case where you want to hide exceptions
while pulling values out of a `Row`.  It seems the only time you should get an exception is
when you are trying to extract a column value using the wrong type.  This seems like a structural
problem with your code (its not dirty data or something transient, its going to fail for every
single row).  As such, I don't think that this is a good addition to the API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message