spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6717][ML] Clear shuffle files after che...
Date Mon, 02 May 2016 07:18:58 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11919#discussion_r61709638
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
    @@ -520,6 +488,81 @@ class ALSSuite
       }
     }
     
    +class ALSCleanerSuite extends SparkFunSuite {
    +  test("Clean shuffles") {
    --- End diff --
    
    This doesn't match the style of the rest of the tests in this file, want me to update
all of them?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message