Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 011BB19CC9 for ; Sun, 10 Apr 2016 15:44:49 +0000 (UTC) Received: (qmail 82798 invoked by uid 500); 10 Apr 2016 15:44:48 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 82776 invoked by uid 500); 10 Apr 2016 15:44:48 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 82765 invoked by uid 99); 10 Apr 2016 15:44:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Apr 2016 15:44:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 49F1DDFE04; Sun, 10 Apr 2016 15:44:48 +0000 (UTC) From: gatorsmile To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org Message-ID: Subject: [GitHub] spark pull request: [SPARK-14518] [SQL] Support Comment in CREATE ... Content-Type: text/plain Date: Sun, 10 Apr 2016 15:44:48 +0000 (UTC) GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/12288 [SPARK-14518] [SQL] Support Comment in CREATE VIEW #### What changes were proposed in this pull request? **HQL Syntax**: [Create View](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-Create/Drop/AlterView ) ```SQL CREATE VIEW [IF NOT EXISTS] [db_name.]view_name [(column_name [COMMENT column_comment], ...) ] [COMMENT view_comment] [TBLPROPERTIES (property_name = property_value, ...)] AS SELECT ...; ``` Add a support for the `[COMMENT view_comment]` clause #### How was this patch tested? Modified the existing test cases to verify the correctness. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gatorsmile/spark addCommentInCreateView Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12288.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12288 ---- commit 9c6ab488f26de0684d16a52313c07fe60262eade Author: gatorsmile Date: 2016-04-10T15:40:46Z support comment in create view ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org