Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: hvanhovell <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-12720-spark@git.apache.org>
In-Reply-To: <git-pr-12720-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-14858][SQL] Enable subquery
 pushdown
Content-Type: text/plain
Message-Id: <20160429223430.C84D9DFD9F@git1-us-west.apache.org>
Date: Fri, 29 Apr 2016 22:34:30 +0000 (UTC)

Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12720#discussion_r61653633
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala ---
    @@ -41,10 +41,7 @@ abstract class SubqueryExpression extends LeafExpression {
       /** Updates the query with new logical plan. */
       def withNewPlan(plan: LogicalPlan): SubqueryExpression
     
    -  /** The correlated conditions that connects the sub-query to its parent query. */
    -  def conditions: Seq[Expression]
    -
    -  protected def conditionString: String = conditions.mkString("[", " && ", "]")
    +  protected def conditionString: String = children.mkString("[", " && ", "]")
    --- End diff --
    
    We can. I just put it there because I need it for correlated scalar subqueries (next PR)...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org