Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-12412-spark@git.apache.org>
In-Reply-To: <git-pr-12412-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-14609][SQL] Native support for
 LOAD DAT...
Content-Type: text/plain
Message-Id: <20160420030648.DBF56DFC70@git1-us-west.apache.org>
Date: Wed, 20 Apr 2016 03:06:48 +0000 (UTC)

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12412#discussion_r60344986
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ---
    @@ -935,6 +935,104 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter {
         sql("DROP TABLE t1")
       }
     
    +  test("LOAD DATA") {
    +    sql(
    +      """
    +        |CREATE EXTERNAL TABLE non_part_table (time TIMESTAMP, id INT)
    +        |ROW FORMAT DELIMITED
    +        |FIELDS TERMINATED BY ','
    +        |LINES TERMINATED BY '\n'
    +      """.stripMargin)
    +
    +    val testData = TestHive.getHiveFile("data/files/issue-4077-data.txt").getCanonicalPath
    +
    +    // LOAD DATA INTO non-partitioned table can't specify partition
    +    intercept[AnalysisException] {
    +      sql(s"""LOAD DATA LOCAL INPATH "$testData" INTO TABLE non_part_table PARTITION(ds="1")""")
    +    }
    +
    +    sql(s"""LOAD DATA LOCAL INPATH "$testData" INTO TABLE non_part_table""")
    +    assert(sql("SELECT time FROM non_part_table LIMIT 2").collect()
    --- End diff --
    
    please use `checkAnswer` here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org