Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0772E19138 for ; Mon, 11 Apr 2016 06:51:40 +0000 (UTC) Received: (qmail 61234 invoked by uid 500); 11 Apr 2016 06:51:40 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 61216 invoked by uid 500); 11 Apr 2016 06:51:39 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 61205 invoked by uid 99); 11 Apr 2016 06:51:39 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 06:51:39 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 890E2DFAB5; Mon, 11 Apr 2016 06:51:39 +0000 (UTC) From: holdenk To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-14298] [ML] [MLlib] Add unit test for E... Content-Type: text/plain Message-Id: <20160411065139.890E2DFAB5@git1-us-west.apache.org> Date: Mon, 11 Apr 2016 06:51:39 +0000 (UTC) Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12286#issuecomment-208187383 We could maybe make this a more complete test and actually check that their are no checkpoint files generated? Although that might be over kill. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org